Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-38908: Fix issue when non runtime_protocol does not raise TypeError #26067

Merged
merged 4 commits into from May 12, 2021
Merged

bpo-38908: Fix issue when non runtime_protocol does not raise TypeError #26067

merged 4 commits into from May 12, 2021

Conversation

uriyyo
Copy link
Member

@uriyyo uriyyo commented May 12, 2021 •
edited by bedevere-bot

@Fidget-Spinner Fidget-Spinner self-requested a review May 12, 2021 14:11
@uriyyo uriyyo changed the title bpo-38908: Fix issue when non runtime_protocol does not raise TypeError bpo-38908: Add tests to cover case when non runtime_protocol does not raise TypeError May 12, 2021
Fidget-Spinner
Fidget-Spinner reviewed May 12, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yurii, thanks for sending a PR to make sure there are no regressions for this long-standing issue!

Lib/test/test_typing.py Outdated Show resolved Hide resolved
@uriyyo uriyyo changed the title bpo-38908: Add tests to cover case when non runtime_protocol does not raise TypeError bpo-38908: Fix issue when non runtime_protocol does not raise TypeError May 12, 2021
@uriyyo @Fidget-Spinner
Update Lib/test/test_typing.py
9c66ec3 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
@uriyyo
Copy link
Member Author

uriyyo commented May 12, 2021

@Fidget-Spinner It is not regression, I made a mistake when said that this issue was not present at 3.11 version. This issue still present and this PR will fix it.

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner It is not regression, I made a mistake when said that this issue was not present at 3.11 version. This issue still present and this PR will fix it.

Oh interesting! class P(Protocol): ... raises as expected, but

class P(Protocol): 
    x : int

doesn't!

@Fidget-Spinner Fidget-Spinner added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 12, 2021
Fidget-Spinner
Fidget-Spinner approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once again, thank you for fixing this!

@uriyyo @Fidget-Spinner
Update Misc/NEWS.d/next/Library/2021-05-12-16-43-21.bpo-38908.nM2_rO.rst
d2baaba 
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>
gvanrossum
gvanrossum approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Does this need backporting?

@gvanrossum gvanrossum merged commit c40486a into python:main May 12, 2021
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @uriyyo for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 12, 2021
@uriyyo @miss-islington
bpo-38908: Fix issue when non runtime_protocol failed to raise TypeEr…
f5a4d3c 
…ror (pythonGH-26067)

(cherry picked from commit c40486a)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
@bedevere-bot
Copy link

GH-26073 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 12, 2021
@miss-islington
Copy link
Contributor

Sorry, @uriyyo and @gvanrossum, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c40486a32d7e37b01ead94e701d69847f5b60e30 3.9

Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this pull request May 12, 2021
@uriyyo @Fidget-Spinner
bpo-38908: Fix issue when non runtime_protocol failed to raise TypeEr…
a1bee7e 
…ror (python#26067)
@Fidget-Spinner
Copy link
Member

Sorry, @uriyyo and @gvanrossum, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c40486a32d7e37b01ead94e701d69847f5b60e30 3.9

I'm on it. It's clashing because the _allow_reckless_class_checks was previously _allow_reckless_class_cheks and the typo fix wasn't backported.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 12, 2021
@bedevere-bot
Copy link

GH-26075 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 12, 2021
@miss-islington @uriyyo
bpo-38908: Fix issue when non runtime_protocol failed to raise TypeEr…
a2d94a0 
…ror (GH-26067)

(cherry picked from commit c40486a)

Co-authored-by: Yurii Karabas <1998uriyyo@gmail.com>
miss-islington pushed a commit that referenced this pull request May 12, 2021
@Fidget-Spinner
[3.9] bpo-38908: Fix issue when non runtime_protocol does not raise T…
88136bb 
…ypeError (GH-26067) (GH-26075)

(cherry picked from commit c40486a)

Co-authored-by: Yurii Karabas 1998uriyyo@gmail.com

Automerge-Triggered-By: GH:gvanrossum
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request May 12, 2021
@Fidget-Spinner
Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol does not…
3ea1c0b 
… raise TypeError (pythonGH-26067) (pythonGH-26075)"

This reverts commit 88136bb.
miss-islington pushed a commit that referenced this pull request May 12, 2021
@Fidget-Spinner
[3.9] Revert "[3.9] bpo-38908: Fix issue when non runtime_protocol do…
9b90ce6 
…es not raise TypeError (GH-26067)" (GH-26077)

Reverts #26075

Automerge-Triggered-By: GH:gvanrossum
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@AlexWaygood AlexWaygood mentioned this pull request Apr 9, 2023
Merged
srittau pushed a commit to python/typing_extensions that referenced this pull request Apr 12, 2023
@AlexWaygood
Fix issue when non runtime_protocol does not raise TypeError (#132)
7e998c2 
Backport of CPython PR 26067 (python/cpython#26067)
This was referenced May 23, 2023
Merged
Merged
@GiaJordan GiaJordan mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

@gvanrossum gvanrossum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@uriyyo @Fidget-Spinner @bedevere-bot @miss-islington @gvanrossum @the-knights-who-say-ni