Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict typing-extensions package to versions before v4.6.0 #1228

Merged
merged 1 commit into from
May 30, 2023

Conversation

GiaJordan
Copy link
Contributor

@GiaJordan GiaJordan commented May 25, 2023

This PR temporarily fixes the issue described in FDS-478 where tests would fail because of using isinstance() in the process of executing the code as normal.

From the typing-extensions changelog, in versions v4.6.0 and up (released May 22, 2023 so 3 days ago):

Backport python/cpython#26067 (originally by Yurii Karabas), ensuring that isinstance() calls on protocols raise TypeError when the protocol is not decorated with @runtime_checkable. Patch by Alex Waygood.

This matches the errors raised during tests when we updated our poetry.toml file and the dependencies in the .lock file were allowed to update as necessary.

Until our relevant classes or possibly in the python client are updated this will cause errors when we run our tests. Pinning the version gives us time to continue development on more pressing issues until we have the bandwidth to make updates to comply with the new requirements. typing-extensions was not a direct dependency for schematic beforehand, but was required by our dependencies so the version was relatively unlocked before this PR.

@GiaJordan GiaJordan changed the base branch from develop to develop-poetry-install-FDS-477 May 25, 2023 22:27
Copy link
Collaborator

@milen-sage milen-sage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GiaJordan I see docutils and mistune packages are removed from poetry.lock. It's likely the removal wouldn't have impact. Do you know why thy are no longer needed though?

@GiaJordan
Copy link
Contributor Author

@milen-sage I'm not sure why they're no longer needed, I wouldn't have expected removals. However, it seems like when they were present they were extras. It could be that the new version of jupyter-server or jupyter-events doesn't need them anymore. I thought that functionality could possibly be handled by the newly added overrides package, but it looks like their functions aren't related.

@milen-sage
Copy link
Collaborator

Yes, this makes sense - thanks for checking!

@GiaJordan
Copy link
Contributor Author

@milen-sage for sure!

@GiaJordan GiaJordan merged commit d76f4c5 into develop-poetry-install-FDS-477 May 30, 2023
3 checks passed
@GiaJordan GiaJordan deleted the develop-FDS-478 branch May 30, 2023 20:22
@MiekoHash
Copy link

Also reported by Adam T via Slack here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants