Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #11850 - Add sys.last_exc #11934

Closed
wants to merge 10 commits into from
Closed

Issue #11850 - Add sys.last_exc #11934

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
358d842
Add sys.last_exc
robotherapist Feb 5, 2024
5171b5d
Add if statement to only use sys.last_exc in versions >= 3.12.0
robotherapist Feb 5, 2024
4ad30d4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 5, 2024
92962b2
Add test and changelog
robotherapist Feb 5, 2024
47b0750
Merge branch 'main' of https://github.com/robotherapist/pytest
robotherapist Feb 5, 2024
bb37b1a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 5, 2024
241b000
Fix errors
robotherapist Feb 5, 2024
9bfeb33
Merge branch 'main' of https://github.com/robotherapist/pytest
robotherapist Feb 5, 2024
4c16dca
Add updated file
robotherapist Feb 5, 2024
d8d9fc6
Merge branch 'main' into main
robotherapist Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ Edison Gustavo Muenz
Edoardo Batini
Edson Tadeu M. Manoel
Eduardo Schettino
Edward Haigh
Eli Boyarski
Elizaveta Shashkova
Éloi Rivard
Expand Down
4 changes: 4 additions & 0 deletions src/_pytest/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,8 @@
del sys.last_type
del sys.last_value
del sys.last_traceback
if sys.version_info >= (3, 12, 0):
del sys.last_exc

Check warning on line 172 in src/_pytest/runner.py

View check run for this annotation

Codecov / codecov/patch

src/_pytest/runner.py#L172 

Added line #L172 was not covered by tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns it the type stub for it is just missing from typeshed (the project which provides type annotations for the standard library). I sent a fix for it, but until it's integrated (in a future mypy version), let's add type-ignores for it, like this:

Suggested change
del sys.last_exc
del sys.last_exc # type: ignore[attr-defined]

except AttributeError:
pass
try:
Expand All @@ -176,6 +178,8 @@
# Store trace info to allow postmortem debugging
sys.last_type = type(e)
sys.last_value = e
if sys.version_info >= (3, 12, 0):
sys.last_exc = e

Check warning on line 182 in src/_pytest/runner.py

View check run for this annotation

Codecov / codecov/patch

src/_pytest/runner.py#L182 

Added line #L182 was not covered by tests
assert e.__traceback__ is not None
# Skip *this* frame
sys.last_traceback = e.__traceback__.tb_next
Expand Down