-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #11850 - Add sys.last_exc #11934
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
358d842
Add sys.last_exc
robotherapist 5171b5d
Add if statement to only use sys.last_exc in versions >= 3.12.0
robotherapist 4ad30d4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 92962b2
Add test and changelog
robotherapist 47b0750
Merge branch 'main' of https://github.com/robotherapist/pytest
robotherapist bb37b1a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 241b000
Fix errors
robotherapist 9bfeb33
Merge branch 'main' of https://github.com/robotherapist/pytest
robotherapist 4c16dca
Add updated file
robotherapist d8d9fc6
Merge branch 'main' into main
robotherapist File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Added the new `sys.last_exc` value to `pytest_runtest_call()` in `src/_pytest/runner.py`. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -168,6 +168,8 @@ | |||||
del sys.last_type | ||||||
del sys.last_value | ||||||
del sys.last_traceback | ||||||
if sys.version_info >= (3, 12, 0): | ||||||
del sys.last_exc | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Turns it the type stub for it is just missing from typeshed (the project which provides type annotations for the standard library). I sent a fix for it, but until it's integrated (in a future mypy version), let's add type-ignores for it, like this:
Suggested change
|
||||||
except AttributeError: | ||||||
pass | ||||||
try: | ||||||
|
@@ -176,6 +178,8 @@ | |||||
# Store trace info to allow postmortem debugging | ||||||
sys.last_type = type(e) | ||||||
sys.last_value = e | ||||||
if sys.version_info >= (3, 12, 0): | ||||||
sys.last_exc = e | ||||||
assert e.__traceback__ is not None | ||||||
# Skip *this* frame | ||||||
sys.last_traceback = e.__traceback__.tb_next | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the changelog is intended for end-users to read, they don't really need to know about details like
pytest_runtest_call
or the internal file it's done in. I suggest something like this: