Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): test on GHA macOS-14 runner #1700

Merged
merged 14 commits into from Feb 10, 2024
Merged

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Dec 16, 2023

PyPA is now on an enterprise plan.
Let's use the new macos-13-xlarge runner in order to test on macOS arm64.

PyPA is now on an enterprise plan.
Let's use the new macos-13-xlarge runner in order to test on macOS arm64.
@mayeut mayeut marked this pull request as draft December 16, 2023 09:25
@mayeut
Copy link
Member Author

mayeut commented Dec 16, 2023

Seems macos-13-xlarge is only available as a paid option (Included minutes cannot be used for larger runners.)
It might be worth discussing this with @pradyunsg who'll have a chat early next year with GitHub folks.

@joerick
Copy link
Contributor

joerick commented Jan 19, 2024

@pradyunsg, quick note from us at cibuildwheel, if you do have another discussion with Github about support of PyPA, it would be great if we could get access to 'larger' runners under the plan.

Testing on macOS arm64 is pretty spotty currently, we only have CirrusCI that supports it and we can't afford to run that on PRs, only on main, as otherwise we run out of quota every month.

Github recently released hosted runners for macOS arm64, but they're of the 'larger' type, which are priced per-minute and seemingly not included in the current plan.

So access to these runners would be great, if at all possible!


edit: nevermind, it looks like the new macos-14 runner solves this problem for us!

lelit added a commit to lelit/pglast that referenced this pull request Jan 22, 2024
Sooner or later cibuildwheel will support testing on that combo, but
right now it emits a warning.

See also pypa/cibuildwheel#1700.
@henryiii
Copy link
Contributor

Looks like M1's are now available generally:

https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

@henryiii henryiii changed the title chore(CI): test on GHA macos-13-xlarge runner chore(CI): test on GHA macos-13 runner Jan 30, 2024
@henryiii henryiii changed the title chore(CI): test on GHA macos-13 runner chore(CI): test on GHA macOS-14 runner Jan 30, 2024
@joerick
Copy link
Contributor

joerick commented Jan 30, 2024

Looks good!

@henryiii
Copy link
Contributor

We can rebase on #1743 once it's in, no need to merge this PR before a patch release, unless you want to.

@joerick
Copy link
Contributor

joerick commented Jan 30, 2024

Lets get the examples and docs updated first. We might as well provide a config that does native compilation on both x86_64 and arm64 while both runners are available IMO.

examples/github-minimal.yml Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
mayeut and others added 3 commits February 6, 2024 06:58
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@mayeut mayeut marked this pull request as ready for review February 6, 2024 06:04
@mayeut mayeut merged commit 81b0a57 into pypa:main Feb 10, 2024
19 checks passed
@mayeut mayeut deleted the macos-13-xlarge branch February 10, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants