Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bother pinning OS images for Github Actions #1734

Merged
merged 4 commits into from
Feb 27, 2024
Merged

Conversation

joerick
Copy link
Contributor

@joerick joerick commented Jan 27, 2024

Fix #1612

The hassle of updating these pins (both for us and our users, most copy our documentation) seems to outweigh the benefit of the pin. The truth is that they're not really pins anyway, Github update them all the time, and they don't work for historical repeatability because old images are retired all the time.

Fix #1612

The hassle of updating these pins (both for us and our users, most copy our documentation) seems to outweigh the benefit of the pin. The truth is that they're not really pins anyway, Github update them all the time, and they don't work for historical repeatability because old images are retired all the time.
@henryiii
Copy link
Contributor

ubuntu-latest is a good idea (we don't use anything really here anyway), but we probably should keep macos-* specified so that the images don't turn in AS by surprise. Once that does happen, then it's fine to use macos-latest (for AS).

@joerick
Copy link
Contributor Author

joerick commented Feb 2, 2024

ah yeah, good point. I'll make that change.

README.md Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
@joerick
Copy link
Contributor Author

joerick commented Feb 18, 2024

Thanks for doing that merge.

@joerick joerick merged commit edd67e0 into main Feb 27, 2024
21 checks passed
@joerick joerick deleted the gha-images-latest branch February 27, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github actions docs use different versions in matrix.os
3 participants