Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop injecting wheel as a build dep fallback #716

Merged
merged 1 commit into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
Changelog
+++++++++


next release
============

- Stopped injecting ``wheel`` as a build dependency automatically, in the
case of missing ``pyproject.toml`` -- by :user:`webknjaz`.
(:pr:`716`)


1.0.3 (2023-09-06)
==================

Expand Down
2 changes: 1 addition & 1 deletion src/build/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

_DEFAULT_BACKEND = {
'build-backend': 'setuptools.build_meta:__legacy__',
'requires': ['setuptools >= 40.8.0', 'wheel'],
'requires': ['setuptools >= 40.8.0'],
}


Expand Down
2 changes: 1 addition & 1 deletion tests/packages/test-invalid-requirements/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build-system]
requires = ['setuptools >= 42.0.0', 'wheel >= 0.36.0', 'this is invalid']
requires = ['setuptools >= 42.0.0', 'this is invalid']
build-backend = 'setuptools.build_meta'
2 changes: 1 addition & 1 deletion tests/packages/test-no-prepare/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[build-system]
build-backend = 'backend_no_prepare'
backend-path = ['.']
requires = ['setuptools >= 42.0.0', 'wheel >= 0.36.0']
requires = ['setuptools >= 42.0.0']
2 changes: 1 addition & 1 deletion tests/packages/test-setuptools/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build-system]
requires = ['setuptools >= 42.0.0', 'wheel >= 0.36.0']
requires = ['setuptools >= 42.0.0']
build-backend = 'setuptools.build_meta'
2 changes: 1 addition & 1 deletion tests/packages/test-typo/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[build_sytem]
requires = ['setuptools >= 40.8.0', 'wheel']
requires = ['setuptools >= 40.8.0']
build-backend = 'setuptools.build_meta'
11 changes: 5 additions & 6 deletions tests/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,12 +230,12 @@ def test_build_package_via_sdist_invalid_distribution(tmp_dir, package_test_setu
[],
[
'* Creating venv isolated environment...',
'* Installing packages in isolated environment... (setuptools >= 42.0.0, wheel >= 0.36.0)',
'* Installing packages in isolated environment... (setuptools >= 42.0.0)',
'* Getting build dependencies for sdist...',
'* Building sdist...',
'* Building wheel from sdist',
'* Creating venv isolated environment...',
'* Installing packages in isolated environment... (setuptools >= 42.0.0, wheel >= 0.36.0)',
'* Installing packages in isolated environment... (setuptools >= 42.0.0)',
'* Getting build dependencies for wheel...',
'* Installing packages in isolated environment... (wheel)',
'* Building wheel...',
Expand All @@ -260,7 +260,7 @@ def test_build_package_via_sdist_invalid_distribution(tmp_dir, package_test_setu
['--wheel'],
[
'* Creating venv isolated environment...',
'* Installing packages in isolated environment... (setuptools >= 42.0.0, wheel >= 0.36.0)',
'* Installing packages in isolated environment... (setuptools >= 42.0.0)',
'* Getting build dependencies for wheel...',
'* Installing packages in isolated environment... (wheel)',
'* Building wheel...',
Expand Down Expand Up @@ -324,7 +324,7 @@ def main_reload_styles():
'ERROR ',
[
'* Creating venv isolated environment...',
'* Installing packages in isolated environment... (setuptools >= 42.0.0, this is invalid, wheel >= 0.36.0)',
'* Installing packages in isolated environment... (setuptools >= 42.0.0, this is invalid)',
'',
'Traceback (most recent call last):',
],
Expand All @@ -334,8 +334,7 @@ def main_reload_styles():
'\33[91mERROR\33[0m ',
[
'\33[1m* Creating venv isolated environment...\33[0m',
'\33[1m* Installing packages in isolated environment... '
'(setuptools >= 42.0.0, this is invalid, wheel >= 0.36.0)\33[0m',
'\33[1m* Installing packages in isolated environment... (setuptools >= 42.0.0, this is invalid)\33[0m',
'',
'\33[2mTraceback (most recent call last):',
],
Expand Down
2 changes: 1 addition & 1 deletion tests/test_projectbuilder.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

DEFAULT_BACKEND = {
'build-backend': 'setuptools.build_meta:__legacy__',
'requires': ['setuptools >= 40.8.0', 'wheel'],
'requires': ['setuptools >= 40.8.0'],
}


Expand Down