Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop injecting wheel as a build dep fallback #716

Merged
merged 1 commit into from
Jan 17, 2024

Commits on Jan 17, 2024

  1. Stop injecting wheel as a build dep fallback

    PEP 517 doesn't mandate depending on `wheel` when a `__legacy__`
    setuptools fallback is used. Historically, it used to be assumed as
    necessary, but later it turned out to be wrong. The reason is that
    `setuptools`' `get_requires_for_build_wheel()` hook already injects
    this dependency when building wheels is requested [[1]].
    It also used to have this hint in the docs, but it was corrected
    earlier [[2]].
    
    This patch removes `wheel` from said `requires` list fallback.
    
    [1]: https://github.com/pypa/setuptools/blob/v40.8.0/setuptools/build_meta.py#L130
    [2]: pypa/setuptools#3056
    webknjaz authored and layday committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    a7e3545 View commit details
    Browse the repository at this point in the history