Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cap the sphinx version under 7.2.0 #2407

Merged
merged 7 commits into from
Aug 19, 2023
Merged

Cap the sphinx version under 7.2.0 #2407

merged 7 commits into from
Aug 19, 2023

Conversation

oddbookworm
Copy link
Member

Addresses #2406

@oddbookworm oddbookworm requested a review from a team as a code owner August 18, 2023 17:35
@oddbookworm oddbookworm linked an issue Aug 18, 2023 that may be closed by this pull request
Sphinx 7.2 breaks documentation headers #2406
Closed
@MyreMylar
Copy link
Member

MyreMylar commented Aug 19, 2023 •
edited

Implemented Ankith's suggested changes, we'll see if that passes the tests.

yunline
yunline approved these changes Aug 19, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ankith26 ankith26 changed the title require sphinx 7.1.2 Cap the sphinx version under 7.2.0 Aug 19, 2023
ankith26
ankith26 approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this for now (though it would still be nice to follow up with sphinx devs for a long-term fix). Gonna merge this so that we aren't blocked on rest of our PRs

@ankith26 ankith26 merged commit 9421000 into pygame-community:main Aug 19, 2023
30 checks passed
@ankith26 ankith26 added this to the 2.3.2 milestone Aug 19, 2023
@oddbookworm oddbookworm mentioned this pull request Aug 19, 2023
Merged
@oddbookworm oddbookworm mentioned this pull request Aug 30, 2023
Closed
@ankith26 ankith26 modified the milestones: 2.3.2, 2.4.0 Sep 2, 2023
@oddbookworm oddbookworm deleted the fix-sphinx branch December 21, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr0id dr0id dr0id left review comments

@MyreMylar MyreMylar MyreMylar approved these changes

@yunline yunline yunline approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
dependencies docs TOP PRIORITY! MUST FIX
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Sphinx 7.2 breaks documentation headers
5 participants
@oddbookworm @MyreMylar @dr0id @yunline @ankith26