Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #2407 #2431

Closed

Conversation

oddbookworm
Copy link
Member

#2407 was to cap the sphinx version due to a breaking change in their behavior. It was fixed and the two most recent releases work again. No need to keep the version capped now
Sphinx issue: sphinx-doc/sphinx#11618

@oddbookworm oddbookworm added docs CI Issue with the Continuous Integration (CI), the actions/bots that test things labels Aug 30, 2023
@oddbookworm oddbookworm requested a review from a team as a code owner August 30, 2023 22:58
@Starbuck5
Copy link
Member

I think we should continue with this pinned. Sphinx will break again in the future for sure, as they have active deprecation and removal cycles.

@oddbookworm
Copy link
Member Author

Closing because Starbuck5 makes a valid point

@oddbookworm oddbookworm closed this Sep 2, 2023
@oddbookworm oddbookworm deleted the remove_sphinx_limits branch December 21, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants