BUG: JS failing to detect "preferred" docs version #1416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
changed the title
drammock
added
kind: bug
|
I checked this PR build and of course everything works just as expected. Note that I also experience the issue ou see in latest. |
12rambau
removed
the
impact: block-release
|
I've removed the block release as it's not failing all the JS anymore. |
yeah it's frustrating that it works fine on PR build but not on main. |
drammock
force-pushed
the
fix-json
branch
2 times, most recently
from
d1f9f16
to
709fe69
Compare
|
fixed / superseded by #1512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
our dev docs have a JS console error about not detecting any "preferred" version of the docs. This PR will try to fix it, but first need to do a bit of debugging. It's severe in that it results in none of the "on page load" JS getting executed (e.g., making our searchbar not work)