Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't display the warning bar if there is an issue #1420

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

12rambau
Copy link
Collaborator

related to #1416

I'm not solving the initial issue itself but I prevent it from blocking the build of the injected code, I would say it's sufficient at the moment to make a release (which would be the first one with the new colors) while we continue working on it.

but don't block the whole javascript page loading
@12rambau 12rambau requested a review from drammock August 23, 2023 12:33
@12rambau 12rambau marked this pull request as ready for review August 23, 2023 12:39
@drammock drammock merged commit fd3f8c5 into pydata:main Aug 23, 2023
19 checks passed
@12rambau 12rambau deleted the javascripts branch August 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants