Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: version switcher on sidebar (#1340) #1342

Merged
merged 1 commit into from Jun 8, 2023
Merged

fix: version switcher on sidebar (#1340) #1342

merged 1 commit into from Jun 8, 2023

Conversation

alphapapa
Copy link
Contributor

Fixes #1340. Thanks to Adam Plowman (@aplowman) for reporting.

With this change, the switcher in the sidebar looks like this when clicked:

fixed

@alphapapa
fix: version switcher on sidebar (pydata#1340)
4449ef8 
Fixes pydata#1340.  Thanks to Adam Plowman (@aplowman) for reporting.
@alphapapa alphapapa mentioned this pull request Jun 6, 2023
Closed
12rambau
12rambau approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this quick fix, nothing to add from my side it works exactly as expected. Note that the failure in Python 3.11 is not related to your modification so I suggest we take care of it in a follow-up PR.

@12rambau 12rambau merged commit d6fdd8b into pydata:main Jun 8, 2023
18 checks passed
@drammock drammock mentioned this pull request Jun 8, 2023
Closed
@tikkss tikkss mentioned this pull request Sep 17, 2023
Closed
@kou kou mentioned this pull request Sep 18, 2023
Merged
kou added a commit to kou/arrow-flight-sql-postgresql that referenced this pull request Sep 19, 2023
@kou
Backport a version switcher fix for mobile
15ca61a 
pydata/pydata-sphinx-theme#1342
@kou kou mentioned this pull request Sep 19, 2023
Merged
kou added a commit to apache/arrow-flight-sql-postgresql that referenced this pull request Sep 19, 2023
@kou
Backport a version switcher fix for mobile (#142)
e494993 
Closes GH-140

pydata/pydata-sphinx-theme#1342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12rambau 12rambau 12rambau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version switcher not opening on mobile
2 participants
@alphapapa @12rambau