Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version switcher seems broken on mobile #140

Closed
tikkss opened this issue Sep 17, 2023 · 4 comments
Closed

Version switcher seems broken on mobile #140

tikkss opened this issue Sep 17, 2023 · 4 comments

Comments

@tikkss
Copy link
Contributor

tikkss commented Sep 17, 2023

Looks like the version switcher on mobile in https://arrow.apache.org/flight-sql-postgresql seems broken.

image

Maybe, updating to pydata-sphinx-theme v0.14.0 will fix it. Please refer to the following.

@kou
Copy link
Member

kou commented Sep 18, 2023

Oh, good catch!
Then it will be fixed eventually because we don't pin pydata-sphinx-theme:

https://arrow.apache.org/flight-sql-postgresql/devel/ will be fixed in the next commit.
https://arrow.apache.org/flight-sql-postgresql/current/ will be fixed in the next release.
But https://arrow.apache.org/flight-sql-postgresql/0.1.0/ unless we don't apply the fix pydata/pydata-sphinx-theme#1342 to https://github.com/apache/arrow-flight-sql-postgresql/blob/asf-site/0.1.0/_static/scripts/pydata-sphinx-theme.js . But the .js was minified...

@tikkss
Copy link
Contributor Author

tikkss commented Sep 18, 2023

Thank you! I see it works well in the next commit and next release.

But the .js was minified...

Oh, I see that this problem is difficult to resolve.

@kou
Copy link
Member

kou commented Sep 19, 2023

Backported.

@kou kou closed this as completed Sep 19, 2023
@tikkss
Copy link
Contributor Author

tikkss commented Sep 19, 2023

Wow! That's cool!

devel website is corrected.
0.1.0 website is corrected.

current website will be fixed in the next release.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants