Fixed literal validator errors for unhashable values #6194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markus1978
force-pushed
the
1.10.X-fixes
branch
2 times, most recently
from
91208b6
to
4d422d8
Compare
markus1978
commented
Jun 20, 2023
pydantic/validators.py
Outdated
| @@ -486,6 +486,9 @@ def make_literal_validator(type_: Any) -> Callable[[Any], Any]: | |||
| allowed_choices = {v: v for v in permitted_choices} | |||
|
|
|||
| def literal_validator(v: Any) -> Any: | |||
| if not isinstance(v, Hashable): | |||
There was a problem hiding this comment.
Wasn't really sure what you prefer here. The alternative to this guard if, would be catching TypeError. Less readable, but would only cause overhead in the error case.
There was a problem hiding this comment.
Catching TypeError as well, would also remove the more or less duplicated core for raising the error. I changed it to catch a TypeError now.
hramezani
approved these changes
Jun 20, 2023
|
Thanks @markus1978 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
If a value is not hashable and used on the dict of expected values a
TypeErroris raised. The code now also catches theTypeErroralong side theKeyErrorto cause the validator to fail with aWrongConstantError.Related issue number
fix #6188
Checklist
changes/<pull request or issue id>-<github username>.mdfile added describing change(see changes/README.md for details)