Fixed literal validator errors for unhashable values (#6188)

pydantic · Jun 20, 2023 · 91208b6 · 91208b6
1 parent ccedd74
commit 91208b6
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 0 deletions.
diff --git a/changes/6188-markus1978.md b/changes/6188-markus1978.md
@@ -0,0 +1 @@
+Fixed literal validator errors for unhashable values.
diff --git a/pydantic/validators.py b/pydantic/validators.py
@@ -486,6 +486,9 @@ def make_literal_validator(type_: Any) -> Callable[[Any], Any]:
     allowed_choices = {v: v for v in permitted_choices}
 
     def literal_validator(v: Any) -> Any:
+        if not isinstance(v, Hashable):
+           raise errors.WrongConstantError(given=str(v), permitted=permitted_choices)
+
         try:
             return allowed_choices[v]
         except KeyError:

diff --git a/tests/test_validators.py b/tests/test_validators.py
@@ -1189,6 +1189,24 @@ class Model(BaseModel):
     ]
 
 
+def test_literal_validator_non_str_value():
+    class Model(BaseModel):
+        a: Literal['foo']
+
+    Model(a='foo')
+
+    with pytest.raises(ValidationError) as exc_info:
+        Model(a={'bar': 'foo'})
+    assert exc_info.value.errors() == [
+        {
+            'loc': ('a',),
+            'msg': "unexpected value; permitted: 'foo'",
+            'type': 'value_error.const',
+            'ctx': {'given': str({'bar': 'foo'}), 'permitted': ('foo',)},
+        }
+    ]
+
+
 def test_literal_validator_str_enum():
     class Bar(str, Enum):
         FIZ = 'fiz'