-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport update to email-validator>=2.0.0.post2 #5627
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e944e28
Backport update to email-validator>=2.0.0.post2
adriangb ba0bf06
fix syntax
adriangb d7a7d2a
try to fix validation?
adriangb 1bf3564
Revert "try to fix validation?"
adriangb 4b0e4e7
return str
adriangb 6247b59
do weird union thing
adriangb 0f539ec
Create 5627-email-validator.md
adriangb 8491550
Rename 5627-email-validator.md to 5627-adriangb.md
adriangb 279b083
support both versions of email-validator
adriangb db3f9a2
bump importlib
adriangb b593e2a
Update setup.py
adriangb File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Update email-validator dependency to >=2.0.0post2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,14 @@ | ||
coverage==6.4.4 | ||
hypothesis==6.54.4 | ||
# pin importlib-metadata as upper versions need typing-extensions to work if on Python < 3.8 | ||
importlib-metadata==3.1.0;python_version<"3.8" | ||
importlib-metadata==3.6.0;python_version<"3.8" | ||
mypy==0.971 | ||
pytest==7.2.1 | ||
pytest-cov==4.0.0 | ||
pytest-mock==3.10.0 | ||
pytest-sugar==0.9.6 | ||
# pin typing-extensions to minimum requirement - see #4885 | ||
typing-extensions==4.2.0 | ||
# used in FastAPI tests, pin to avoid warnings in newer version | ||
# that FastAPI needs to fix | ||
Flask==2.2.3 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the exact same code we had previously. To avoid adding a whole CI run just to test this version of email-validator, we are going to leave it uncovered. I ran locally and all tests pass with email-validator <2. This is also being run via the FastAPI tests, it's just not counted towards coverage.