Backport update to email-validator>=2.0.0.post2 #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d7a7d2a.
3 tasks
|
@tiangolo looks like we're blocked by this: https://github.com/tiangolo/fastapi/blob/8ac8d70d52bb0dd9eb55ba4e22d3e383943da05c/pyproject.toml#L62 Any chance you could cut a FastAPI patch release that removes the upper version pin? |
Deploying with
|
| Latest commit: |
b593e2a
|
| Status: | 🚫 Build failed. |
adriangb
commented
Apr 29, 2023
Comment on lines
+733
to
+739
| else: | ||
| # email-validator >1, <2 | ||
| at_index = email.index('@') | ||
| local_part = email[:at_index] # RFC 5321, local part must be case-sensitive. | ||
| global_part = email[at_index:].lower() | ||
|
|
||
| return name or local_part, local_part + global_part |
There was a problem hiding this comment.
This is the exact same code we had previously. To avoid adding a whole CI run just to test this version of email-validator, we are going to leave it uncovered. I ran locally and all tests pass with email-validator <2. This is also being run via the FastAPI tests, it's just not counted towards coverage.
|
please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3905
Selected Reviewer: @samuelcolvin