Adding configuration documentation changes for username_file support for basic auth http client config #12749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t basic auth Signed-off-by: Wasim Nihal <sswasim64@gmail.com>
|
Please find the code changes PR at prometheus/common#511 |
|
@roidelapluie Could you take a look? At first glance this looks correct. @wasim-nihal could you rebase your PR to fix the conflict? We looked at this in our bug scrub. |
|
@gouthamve , I have rebased the PR. Can you please review? |
|
@roidelapluie could you have a look at this once? Currently, the documentation (https://prometheus.io/docs/prometheus/latest/configuration/configuration/#scrape_config) is not update with the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including documentation changes to have
username_fileoption for basic auth configuration.Changes for the ticket: #12576
@roidelapluie , request you to review the changes.