Adding support for file based configuration of basic auth username in http client config #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent config. Signed-off-by: Wasim Nihal <sswasim64@gmail.com>
|
Please find the configuration documentation changes at prometheus/prometheus#12749 |
roidelapluie
requested changes
Aug 31, 2023
config/http_config.go
Outdated
| } | ||
|
|
||
| func (rt *basicAuthRoundTripper) RoundTrip(req *http.Request) (*http.Response, error) { | ||
| if len(req.Header.Get("Authorization")) != 0 { | ||
| return rt.rt.RoundTrip(req) | ||
| } | ||
| username, err := getBasicAuthUsername(*rt) |
There was a problem hiding this comment.
I don't think extra funtions are needed of they do not share code
There was a problem hiding this comment.
addressed the comment. Moved this logic back to the basic auth RoundTrip method.
…ent config. Signed-off-by: Wasim Nihal <sswasim64@gmail.com>
Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Nihal <38865967+wasim-nihal@users.noreply.github.com>
Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Nihal <38865967+wasim-nihal@users.noreply.github.com>
…common into username-file-12576 Signed-off-by: Wasim Nihal <sswasim64@gmail.com>
…common into username-file-12576 Signed-off-by: Wasim Nihal <sswasim64@gmail.com>
…common into username-file-12576
|
@roidelapluie, I have addressed the above review comments. Request you to review the changes |
roidelapluie
approved these changes
Sep 4, 2023
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including changes to have
username_fileoption for basic auth configuration.Changes for the ticket: prometheus/prometheus#12576
@roidelapluie , request you to review the changes.