Allow custom log.Logger #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
obalunenko
reviewed
Apr 24, 2023
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
|
@obalunenko Can I help here to move forward here? How many approvals are need to a merge? |
|
I suppose you have to ask @kakkoyun or @roidelapluie for a review and merge - as they're maintainers of this repo |
|
@kakkoyun or @roidelapluie: could you please take a look here? |
|
@SuperQ could you make take a look at this? As see some maintainer activity from your point of view. |
|
lolol, github outage duplicated my LGTM. |
|
:D are you also responsable for merge it? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow to use custom log.Logger together with the promlog wrapper mechanics and can be considered as alternative to copy, own and manually patch as needed.
A potential use case is using promlog with an Windows Event Log backend.
Not sure, if you are willing to include Windows EventLog support by default.