Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to go-kit logger #1192

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Apr 22, 2023

Fixes #979
Replaces #987

See

for similar changes

depends on


This is a breaking change for the log.format CLI flags.

  • --log.format logger:stderr -> --log.file stderr --log.format logfmt
  • --log.format logger:stdout?json=true -> --log.file stdout --log.format json
  • --log.format logger:eventlog?name=windows_exporter -> --log.file eventlog

The breaking change happens on node_exporter before version 1, too. They dont add any backwards compability.

windows_exporter is still < version 1. In terms of semver, a breaking change is fine here.

collector/iis.go Outdated Show resolved Hide resolved
@jkroepke jkroepke marked this pull request as ready for review May 12, 2023 17:35
@jkroepke jkroepke requested a review from a team as a code owner May 12, 2023 17:35
@jkroepke
Copy link
Member Author

@breed808 can you do take a look here?

@jkroepke
Copy link
Member Author

jkroepke commented Jun 8, 2023

@breed808 I would appreciate a review here.

@jkroepke jkroepke force-pushed the custom-logger branch 2 times, most recently from dd8ec18 to 45f9149 Compare June 12, 2023 17:51
@jkroepke
Copy link
Member Author

rebased

@jkroepke
Copy link
Member Author

@breed808 I would appreciate a review here, please let me know, if I can assist here.

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for my absence in reviewing this. Thanks very much for the time and effort you've put into this change, it's another really good PR 😄

I've left a few minor comments, but aside from those I have no issues with change proposed by this PR.

log/logger.go Outdated Show resolved Hide resolved
collector/container.go Outdated Show resolved Hide resolved
collector/time.go Outdated Show resolved Hide resolved
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke
Copy link
Member Author

jkroepke commented Jul 9, 2023

I addressed all your changes. I hope thats fine now.

Copy link
Contributor

@breed808 breed808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for integrating those changes 👍

@breed808 breed808 merged commit 4077290 into prometheus-community:master Jul 10, 2023
5 checks passed
@jkroepke jkroepke deleted the custom-logger branch July 10, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to log to a file (rather than stdout / stderr / eventlog)
2 participants