Update Go versions #447
Update Go versions #447
Conversation
SuperQ
commented
Feb 20, 2023
•
SuperQ
commented
- Add Go 1.20.
- Set minimum Go version to 1.18.
- Bump golang.org/x/net.
SuperQ
force-pushed
the
superq/bump_go
branch
2 times, most recently
from
5fc0b0f
to
65d8915
Compare
|
client_golang depends on this ; have they / will they also bump the go version requirement? |
|
Added client_golang maintainers to this. |
|
IIRC we are usually trying to support the last three Go minor releases. From that perspective, Go1.19 would be fine once Go1.21 is out. But I might misremember, and I'm pretty sure it was always a best-effort thing. (Although it's usually easy with build tags etc. to maintain backwards compatibility even if using more recent Go features.) |
|
@beorn7 We used to do that, but recently we have been only trying to support only what Go officially supports. |
SuperQ
force-pushed
the
superq/bump_go
branch
from
65d8915
to
95dee7d
Compare
* Add Go 1.20. * Set minimum Go version to 1.18. * Bump golang.org/x/net. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/bump_go
branch
from
95dee7d
to
2cd3d6e
Compare
|
Ok, I added Go 1.18 back in. I still want to get sign-off from both client_golang and prometheus maintainers. |
|
I won't have access to a computer until Sunday. If it's urgent, leaving the decision to @bwplotka |
|
LGTM, thanks for keeping 1.18 in, not big harm here to keep it IMO. |
|
Thanks! |
