Bump golangci-lint to v1.50.1 #425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mem
reviewed
Dec 17, 2022
| with: | ||
| go-version: 1.18.x | ||
| go-version-file: go.mod |
There was a problem hiding this comment.
Looking at what the action does, I don't think this is going to have any effect except if ruleguard is configured. It should be OK.
|
makefile.common comes from prometheus/prometheus and should be update here |
lucacome
force-pushed
the
bump-golangci-lint
branch
from
1d01170
to
1951919
Compare
|
I've rebased the PR, should be good to go I think? |
Signed-off-by: Luca Comellini <luca.com@gmail.com>
lucacome
force-pushed
the
bump-golangci-lint
branch
from
1951919
to
710bde7
Compare
|
@roidelapluie can it be merged? |
|
Fixed in #447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
golangci-lint aligning CI and Makefilev3.3.1v3to be able to read Go version fromgo.mod