Adjust supported python versions to ^3.8 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamon
force-pushed
the
jhamon/explore-python-dep-versions
branch
from
2c57361
to
d317cde
Compare
jhamon
force-pushed
the
jhamon/explore-python-dep-versions
branch
from
69b9dfc
to
5a6c5c6
Compare
jhamon
commented
Feb 21, 2024
Comment on lines
+106
to
+107
| - 1.59.3 | ||
| - 1.60.0 |
There was a problem hiding this comment.
This range is different for 3.11 and 3.12 vs earlier versions.
jhamon
commented
Feb 22, 2024
| @@ -47,15 +48,21 @@ classifiers=[ | |||
| ] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.8,<3.13" | |||
| python = "^3.8" | |||
There was a problem hiding this comment.
This was the requested change that motivated me to start poking around with this.
jhamon
commented
Feb 22, 2024
| pytest-asyncio = "0.15.1" | ||
| pytest-cov = "2.10.1" | ||
| pytest-mock = "3.6.1" | ||
| pytest-timeout = ">=1.4.2" | ||
| pytest-timeout = "2.2.0" |
There was a problem hiding this comment.
We needed to bump these pytest dev dependencies to work with python 3.12.
jhamon
changed the title
austin-denoble
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Extend test coverage for python 3.11 and 3.12. Adjust pyproject.toml python dependency to
^3.8to ease some installation problems in projects which depend on us.Solution
Tweak test matrix to add coverage for 3.11 and 3.12. Adjust pyproject.toml to reflect specific version deps for grpcio and urllib3.
Type of Change
Test Plan
Describe specific steps for validating this change.