-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust supported python versions to ^3.8 #312
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
86505c0
Rebase
jhamon 8cb0ccd
github actions does not support yaml anchors
jhamon 070341b
Adjust test matrix
jhamon 5a6c5c6
Add coverage in data plane integration tests
jhamon 31586c3
Fix typo in CI config
jhamon 9f35aef
Move dependency testing into reusable actions
jhamon 2fd0239
Fix typo in CI config
jhamon acfd66c
Fix typo in dep test action
jhamon 97286a4
Update package metadata
jhamon File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
name: 'Test GRPC Dependencies' | ||
description: 'Runs sanity test with specific gRPC dependencies' | ||
|
||
inputs: | ||
PINECONE_API_KEY: | ||
description: 'The Pinecone API key' | ||
required: true | ||
index_name: | ||
description: 'The name of the index' | ||
required: true | ||
python_version: | ||
description: 'The version of Python to use' | ||
required: false | ||
default: '3.9' | ||
grpcio_version: | ||
description: 'The version of grpcio to install' | ||
required: true | ||
lz4_version: | ||
description: 'The version of lz4 to install' | ||
required: true | ||
protobuf_version: | ||
description: 'The version of protobuf to install' | ||
required: true | ||
googleapis_common_protos_version: | ||
description: 'The version of googleapis-common-protos to install' | ||
required: true | ||
|
||
runs: | ||
using: 'composite' | ||
steps: | ||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ inputs.python_version }} | ||
|
||
- name: Setup Poetry | ||
uses: ./.github/actions/setup-poetry | ||
with: | ||
include_grpc: true | ||
include_types: false | ||
|
||
- name: Install grpcio ${{ inputs.grpcio_version }} | ||
run: poetry add grpcio==${{ inputs.grpcio_version }} | ||
shell: bash | ||
|
||
- name: Install lz4 ${{ inputs.lz4_version }} | ||
run: poetry add lz4==${{ inputs.lz4_version }} | ||
shell: bash | ||
|
||
- name: Install protobuf ${{ inputs.protobuf_version }} | ||
run: poetry add protobuf==${{ inputs.protobuf_version }} | ||
shell: bash | ||
|
||
- name: Install googleapis-common-protos ${{ inputs.googleapis_common_protos_version }} | ||
run: poetry add googleapis-common-protos==${{ inputs.googleapis_common_protos_version }} | ||
shell: bash | ||
|
||
- uses: nick-fields/retry@v3 | ||
with: | ||
timeout_minutes: 5 | ||
max_attempts: 3 | ||
retry_on: error | ||
command: poetry run pytest tests/dependency/grpc -s -v | ||
env: | ||
PINECONE_API_KEY: ${{ inputs.PINECONE_API_KEY }} | ||
INDEX_NAME: ${{ inputs.index_name }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
name: 'Test REST Dependencies' | ||
description: 'Runs sanity test with specific REST dependencies' | ||
|
||
inputs: | ||
PINECONE_API_KEY: | ||
description: 'The Pinecone API key' | ||
required: true | ||
index_name: | ||
description: 'The name of the index' | ||
required: true | ||
python_version: | ||
description: 'The version of Python to use' | ||
required: false | ||
default: '3.9' | ||
urllib3_version: | ||
description: 'The version of urllib3 to install' | ||
required: true | ||
|
||
runs: | ||
using: 'composite' | ||
steps: | ||
- name: Set up Python | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ inputs.python_version }} | ||
|
||
- name: Setup Poetry | ||
uses: ./.github/actions/setup-poetry | ||
with: | ||
include_grpc: false | ||
include_types: false | ||
|
||
- name: 'Install urllib3 ${{ matrix.urllib3-version }}' | ||
run: 'poetry add urllib3==${{ matrix.urllib3-version }}' | ||
shell: bash | ||
|
||
- uses: nick-fields/retry@v3 | ||
with: | ||
timeout_minutes: 5 | ||
max_attempts: 3 | ||
retry_on: error | ||
command: poetry run pytest tests/dependency/rest -s -v | ||
env: | ||
PINECONE_API_KEY: '${{ inputs.PINECONE_API_KEY }}' | ||
INDEX_NAME: '${{ inputs.index_name }}' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,6 +13,7 @@ jobs: | |
- 3.9 | ||
- '3.10' | ||
- 3.11 | ||
- 3.12 | ||
use_grpc: | ||
- true | ||
- false | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This range is different for 3.11 and 3.12 vs earlier versions.