-
Notifications
You must be signed in to change notification settings - Fork 68
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adjust supported python versions to ^3.8 (#312)
## Problem Extend test coverage for python 3.11 and 3.12. Adjust pyproject.toml python dependency to `^3.8` to ease some installation problems in projects which depend on us. ## Solution Tweak test matrix to add coverage for 3.11 and 3.12. Adjust pyproject.toml to reflect specific version deps for grpcio and urllib3. ## Type of Change - [x] New feature (non-breaking change which adds functionality) - [x] Infrastructure change (CI configs, etc) ## Test Plan Describe specific steps for validating this change.
- Loading branch information
Showing
9 changed files
with
227 additions
and
107 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| name: 'Test GRPC Dependencies' | ||
| description: 'Runs sanity test with specific gRPC dependencies' | ||
|
|
||
| inputs: | ||
| PINECONE_API_KEY: | ||
| description: 'The Pinecone API key' | ||
| required: true | ||
| index_name: | ||
| description: 'The name of the index' | ||
| required: true | ||
| python_version: | ||
| description: 'The version of Python to use' | ||
| required: false | ||
| default: '3.9' | ||
| grpcio_version: | ||
| description: 'The version of grpcio to install' | ||
| required: true | ||
| lz4_version: | ||
| description: 'The version of lz4 to install' | ||
| required: true | ||
| protobuf_version: | ||
| description: 'The version of protobuf to install' | ||
| required: true | ||
| googleapis_common_protos_version: | ||
| description: 'The version of googleapis-common-protos to install' | ||
| required: true | ||
|
|
||
| runs: | ||
| using: 'composite' | ||
| steps: | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ inputs.python_version }} | ||
|
|
||
| - name: Setup Poetry | ||
| uses: ./.github/actions/setup-poetry | ||
| with: | ||
| include_grpc: true | ||
| include_types: false | ||
|
|
||
| - name: Install grpcio ${{ inputs.grpcio_version }} | ||
| run: poetry add grpcio==${{ inputs.grpcio_version }} | ||
| shell: bash | ||
|
|
||
| - name: Install lz4 ${{ inputs.lz4_version }} | ||
| run: poetry add lz4==${{ inputs.lz4_version }} | ||
| shell: bash | ||
|
|
||
| - name: Install protobuf ${{ inputs.protobuf_version }} | ||
| run: poetry add protobuf==${{ inputs.protobuf_version }} | ||
| shell: bash | ||
|
|
||
| - name: Install googleapis-common-protos ${{ inputs.googleapis_common_protos_version }} | ||
| run: poetry add googleapis-common-protos==${{ inputs.googleapis_common_protos_version }} | ||
| shell: bash | ||
|
|
||
| - uses: nick-fields/retry@v3 | ||
| with: | ||
| timeout_minutes: 5 | ||
| max_attempts: 3 | ||
| retry_on: error | ||
| command: poetry run pytest tests/dependency/grpc -s -v | ||
| env: | ||
| PINECONE_API_KEY: ${{ inputs.PINECONE_API_KEY }} | ||
| INDEX_NAME: ${{ inputs.index_name }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: 'Test REST Dependencies' | ||
| description: 'Runs sanity test with specific REST dependencies' | ||
|
|
||
| inputs: | ||
| PINECONE_API_KEY: | ||
| description: 'The Pinecone API key' | ||
| required: true | ||
| index_name: | ||
| description: 'The name of the index' | ||
| required: true | ||
| python_version: | ||
| description: 'The version of Python to use' | ||
| required: false | ||
| default: '3.9' | ||
| urllib3_version: | ||
| description: 'The version of urllib3 to install' | ||
| required: true | ||
|
|
||
| runs: | ||
| using: 'composite' | ||
| steps: | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ inputs.python_version }} | ||
|
|
||
| - name: Setup Poetry | ||
| uses: ./.github/actions/setup-poetry | ||
| with: | ||
| include_grpc: false | ||
| include_types: false | ||
|
|
||
| - name: 'Install urllib3 ${{ matrix.urllib3-version }}' | ||
| run: 'poetry add urllib3==${{ matrix.urllib3-version }}' | ||
| shell: bash | ||
|
|
||
| - uses: nick-fields/retry@v3 | ||
| with: | ||
| timeout_minutes: 5 | ||
| max_attempts: 3 | ||
| retry_on: error | ||
| command: poetry run pytest tests/dependency/rest -s -v | ||
| env: | ||
| PINECONE_API_KEY: '${{ inputs.PINECONE_API_KEY }}' | ||
| INDEX_NAME: '${{ inputs.index_name }}' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,6 +13,7 @@ jobs: | |
| - 3.9 | ||
| - '3.10' | ||
| - 3.11 | ||
| - 3.12 | ||
| use_grpc: | ||
| - true | ||
| - false | ||
|
|
||
Oops, something went wrong.