Reproduce bug 10449 #10508
Reproduce bug 10449 #10508
Conversation
.github/workflows/other-tests.yml
Outdated
| script: | | ||
| cd e2e/bug10449 | ||
| composer install | ||
| ../../phpstan analyze --error-format=json --no-progress | jq '.files[].messages[].message' | grep "Dumped type: string" |
There was a problem hiding this comment.
You should express this with something that can be baselined, like passing an argument to a method call.
|
|
||
| public function __invoke(): string | ||
| { | ||
| $value = $this->queryBus->handle(new Query\ExampleQuery()); |
There was a problem hiding this comment.
in this test-case the bug is triggered because of this New_
|
|
||
| public function __invoke($x): string | ||
| { | ||
| if ($x instanceof Query\ExampleQuery) |
There was a problem hiding this comment.
in this test-case the same error is triggered based on Instanceof_
There was a problem hiding this comment.
Oh my god, I am so sorry. I have just noticed this is in phpstan/phpstan and not in phpstan/phpstan-src. I was puzzled that I don't see other result cache-related tests when I expanded the surrounding lines in the diff in the workflow file.
Previously yout put this correctly in there (phpstan/phpstan-src@38eb365) so why did you suddenly choose to do it here instead? I'd prefer for this to be alongside other result cache tests.
|
I miss-remembered where to put the result-cache e2e tests. |
refs #10449 (comment)