Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix result-cache with phpstan-types on New_ references #2894

Merged
merged 5 commits into from Jan 30, 2024
Merged

Fix result-cache with phpstan-types on New_ references #2894

merged 5 commits into from Jan 30, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jan 30, 2024 •
edited

@staabm
Copy link
Contributor Author

staabm commented Jan 30, 2024 •
edited

I think the fix is not correct, as we have the same problem in more places. let me just have another look

refactored with 45307b9 so the fix also works for phpstan-types referenced via Catch_, Instanceof_ or similar references

@staabm staabm marked this pull request as ready for review January 30, 2024 15:36
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@ondrejmirtes ondrejmirtes merged commit ea52b59 into phpstan:1.10.x Jan 30, 2024
430 of 431 checks passed
@ondrejmirtes ondrejmirtes mentioned this pull request Jan 30, 2024
Closed
@staabm staabm deleted the fix-cache branch January 30, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@staabm @phpstan-bot @ondrejmirtes