Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary method calls in ClassReflection #2984

Merged
merged 3 commits into from Mar 22, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 22, 2024

drive-by cleanups while analyzing the cause of phpstan/phpstan#10772

@staabm
Copy link
Contributor Author

staabm commented Mar 22, 2024

before this PR:

$ time vendor/bin/phpstan analyse --debug
Note: Using configuration file C:\dvl\Workspace\stan-long\phpstan.neon.
C:\dvl\Workspace\stan-long\src\test.php


 [OK] No errors



real    2m8.411s
user    0m0.000s
sys     0m0.000s


after the 2 commits

$ time ../phpstan-src/bin/phpstan analyse --debug
Note: Using configuration file C:\dvl\Workspace\stan-long\phpstan.neon.
C:\dvl\Workspace\stan-long\src\test.php


 [OK] No errors



real    1m16.387s
user    0m0.000s
sys     0m0.015s

not perfect but waaay faster. still investigating..

@ondrejmirtes ondrejmirtes merged commit 4c167d7 into phpstan:1.10.x Mar 22, 2024
436 of 441 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm staabm deleted the cheap-first2 branch March 22, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants