Remove unnecessary method calls in ClassReflection

phpstan · Mar 22, 2024 · 4c167d7 · 4c167d7
1 parent 944673f
commit 4c167d7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/Reflection/ClassReflection.php b/src/Reflection/ClassReflection.php
@@ -688,7 +688,7 @@ public function isTrait(): bool
 	 */
 	public function isEnum(): bool
 	{
-		return $this->reflection->isEnum() && $this->reflection instanceof ReflectionEnum;
+		return $this->reflection instanceof ReflectionEnum && $this->reflection->isEnum();
 	}
 
 	public function isReadOnly(): bool
@@ -737,10 +737,11 @@ public function getEnumCases(): array
 		}
 
 		$cases = [];
+		$initializerExprContext = InitializerExprContext::fromClassReflection($this);
 		foreach ($this->reflection->getCases() as $case) {
 			$valueType = null;
 			if ($case instanceof ReflectionEnumBackedCase) {
-				$valueType = $this->initializerExprTypeResolver->getType($case->getValueExpression(), InitializerExprContext::fromClassReflection($this));
+				$valueType = $this->initializerExprTypeResolver->getType($case->getValueExpression(), $initializerExprContext);
 			}
 			/** @var string $caseName */
 			$caseName = $case->getName();
@@ -982,10 +983,10 @@ public function getTraits(bool $recursive = false): array
 	public function getParentClassesNames(): array
 	{
 		$parentNames = [];
-		$currentClassReflection = $this;
-		while ($currentClassReflection->getParentClass() !== null) {
-			$parentNames[] = $currentClassReflection->getParentClass()->getName();
-			$currentClassReflection = $currentClassReflection->getParentClass();
+		$parentClass = $this->getParentClass();
+		while ($parentClass !== null) {
+			$parentNames[] = $parentClass->getName();
+			$parentClass = $parentClass->getParentClass();
 		}
 
 		return $parentNames;

diff --git a/src/Type/ObjectType.php b/src/Type/ObjectType.php
@@ -1217,11 +1217,12 @@ public function getEnumCases(): array
 		}
 
 		$cases = [];
+		$className = $classReflection->getName();
 		foreach ($classReflection->getEnumCases() as $enumCase) {
 			if (array_key_exists($enumCase->getName(), $subtracted)) {
 				continue;
 			}
-			$cases[] = new EnumCaseObjectType($classReflection->getName(), $enumCase->getName(), $classReflection);
+			$cases[] = new EnumCaseObjectType($className, $enumCase->getName(), $classReflection);
 		}
 
 		return $cases;