error_log() is impure #2884
Merged
error_log() is impure #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Jan 22, 2024
| @@ -1423,6 +1423,7 @@ public function dataFileAsserts(): iterable | |||
| yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-10302-interface-extends.php'); | |||
| yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-10302-trait-extends.php'); | |||
| yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-10302-trait-implements.php'); | |||
| yield from $this->gatherAssertTypes(__DIR__ . '/data/impure-error-log.php'); | |||
There was a problem hiding this comment.
Please don't put at the end, but somewhere random in the middle. This is to prevent conflicts when merging into 1.11.x
| $logfile = 'bar/baz.txt'; | ||
| if (!error_log($message, 3, $logfile)) { | ||
| assertType('bool', error_log($message, 3, $logfile)); | ||
| } |
There was a problem hiding this comment.
Please always put the code you're testing into an anonymous function. The root scope behaves a little bit differently (see Scope::canAnyVariableExist()) and when we are not testing something specific to the root scope I like to avoid issues with that.
There was a problem hiding this comment.
right, forgot about that. thanks for the headsup.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#10437