error_log() is impure

phpstan · Jan 22, 2024 · 7c75d21 · 7c75d21
1 parent a3d0910
commit 7c75d21
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 0 deletions.
diff --git a/bin/functionMetadata_original.php b/bin/functionMetadata_original.php
@@ -72,6 +72,7 @@
 	'count' => ['hasSideEffects' => false],
 	'connection_aborted' => ['hasSideEffects' => true],
 	'connection_status' => ['hasSideEffects' => true],
+	'error_log' => ['hasSideEffects' => true],
 	'fclose' => ['hasSideEffects' => true],
 	'fflush' => ['hasSideEffects' => true],
 	'fgetc' => ['hasSideEffects' => true],

diff --git a/resources/functionMetadata.php b/resources/functionMetadata.php
@@ -861,6 +861,7 @@
 	'dngettext' => ['hasSideEffects' => false],
 	'doubleval' => ['hasSideEffects' => false],
 	'error_get_last' => ['hasSideEffects' => false],
+	'error_log' => ['hasSideEffects' => true],
 	'escapeshellarg' => ['hasSideEffects' => false],
 	'escapeshellcmd' => ['hasSideEffects' => false],
 	'exp' => ['hasSideEffects' => false],

diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -1393,6 +1393,7 @@ public function dataFileAsserts(): iterable
 			yield from $this->gatherAssertTypes(__DIR__ . '/data/trigger-error-php7.php');
 		}
 
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/impure-error-log.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/falsy-isset.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/falsey-coalesce.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/falsey-ternary-certainty.php');

diff --git a/tests/PHPStan/Analyser/data/impure-error-log.php b/tests/PHPStan/Analyser/data/impure-error-log.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace ImpureErrorLog;
+
+use function PHPStan\Testing\assertType;
+
+function doFoo() {
+	$message = 'foo';
+	$logfile = 'bar/baz.txt';
+	if (!error_log($message, 3, $logfile)) {
+		assertType('bool', error_log($message, 3, $logfile));
+	}
+}
+