More precise inotify related function signatures #2599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
inotify_add_watch
: Narrowed the returned value: It can only be a non-negative integer according to the man pageinotify_add_watch
: Addedfalse
in case of failure, same concept asfopen()
, in case the file does not exist or is not readableinotify_queue_len
: Narrowed the return value: It can only be zero or positiveinotify_read
: Narrowed the return value: Added the shape of the returned arrayinotify_read
: Addedfalse
in case the stream is set a non-blocking.Question: I have a doubt about point 5, i.e. adding
false
as possible return type toinotify_read
. This can only happen if the inotify stream is set as non-blocking (tested). Should this go to the bleeding version of the signatures map?