Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect doc for inotify_read #2605

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix incorrect doc for inotify_read #2605

merged 1 commit into from
Sep 5, 2023

Conversation

taka-oyama
Copy link
Contributor

@taka-oyama taka-oyama commented Sep 5, 2023

#2599 attempted to improve the doc for inotify_read but the return type is incorrect (returns an inotify event but should return array of inotify events) and threw an error in our code.
This attempts to fix that.

Here is the snippet of our code.
https://phpstan.org/r/bb53cbfc-68cb-44d7-aed8-7efbd7438651

@ondrejmirtes ondrejmirtes merged commit ebf36ff into phpstan:1.10.x Sep 5, 2023
410 of 414 checks passed
@ondrejmirtes
Copy link
Member

Thank you.

@taka-oyama taka-oyama deleted the 1.10.x branch September 5, 2023 08:16
@thg2k
Copy link
Contributor

thg2k commented Sep 5, 2023

I'm deeply sorry about that. Unfortunately at the same time I was submitting this change I also stumbled upon phpstan/phpstan#8296 and I did not notice this trivial mistake. I just realised that by-ref parameters are not checked, and I was passing the inotify_read result to a function mangling the record, together with param-out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants