Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to share state between my
RpcModule
and another service.Because
RpcModule
onlyDeref
s toContext
, I have to have a secondArc
, and my handlers have to acceptArc<Arc<Context>>
.This would allow me to clone the inner context, obviating the need for the double indirection.
Alternative approaches:
Deref<Target = Arc<Context>>
. I think this is backwards-compatible.RpcModule::new(_: impl Into<Arc<Context>>)
, which is backwards-compatible.I could clone the arc before passing it to the ctor, where it would stay without a new
Arc