Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve jsonrpsee RpcModule ergonomics #4007

Closed
3 tasks done
elmattic opened this issue Feb 28, 2024 · 1 comment · Fixed by #4115
Closed
3 tasks done

Improve jsonrpsee RpcModule ergonomics #4007

elmattic opened this issue Feb 28, 2024 · 1 comment · Fixed by #4115
Assignees

Comments

@elmattic
Copy link
Contributor

elmattic commented Feb 28, 2024

Issue summary

This is a follow-up of #3978.

We had to build an Arc<RPCState> to create two jsonrpsee's RPC modules in Forest.

However, a RpcModule internally creates an Arc.
This results in having to use Arc<Arc<State>> at many places, but that would not be strictly necessary if we could create an RPC module from an Arc.

Task summary

  • Add the new constructor in jsonrpsee crate
  • Get the PR approved
  • Remove one Arc level from our Data type alias

Other information and links

https://docs.rs/jsonrpsee-core/0.21.0/src/jsonrpsee_core/server/rpc_module.rs.html#470

@aatifsyed
Copy link
Contributor

paritytech/jsonrpsee#1324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants