✨ Use local dockerfile instead of pre-built image #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping. Any questions? |
azeemshaikh38
approved these changes
Jan 4, 2022
| @@ -42,5 +42,5 @@ branding: | |||
|
|
|||
| runs: | |||
| using: "docker" | |||
| image: "docker://laurentsimon/scorecard-action:latest" | |||
| image: "./Dockerfile" | |||
There was a problem hiding this comment.
Nit: maybe remove the ./ as shown in the example provided by GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #35, it seems only the docker registry is supported. So instead of finding a way to publish there, let's use a local dockerfile. This PR does just that. It also updates the hash of the scorecard's image to the latest in order to cut a pre-release and start testing.
All in all, this also simplifies the release process for the action. I've updated the release process accordingly in #33
closes #35