Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Support for ghcr.io in Action #35

Closed
laurentsimon opened this issue Dec 30, 2021 · 2 comments · Fixed by #38
Closed

🐛 Support for ghcr.io in Action #35

laurentsimon opened this issue Dec 30, 2021 · 2 comments · Fixed by #38

Comments

@laurentsimon
Copy link
Contributor

laurentsimon commented Dec 30, 2021

I tried using the image generated by our release workflow.
When using ghcr.io in the action:

runs:
  using: "docker"
  image: "ghcr.io://ossf/scorecard-action:latest"

I got the following error

'ghcr.io://ossf/scorecard-action:latest' should be either '[path]/Dockerfile' or 'docker://image[:tag]'

When trying

runs:
  using: "ghcr.io"
  image: "ghcr.io://ossf/scorecard-action:latest"

I got

Error: System.ArgumentOutOfRangeException: Specified argument was out of the range of valid values. (Parameter ''using: ghcr.io' is not supported, use 'docker', 'node12' or 'node16' instead.')

@naveensrinivasan am I doing something wrong or is docker registry the only registry supported?
cc @azeemshaikh38

@azeemshaikh38
Copy link
Contributor

See image below. 2 things:

  1. Looks like we can use a non Docker hub image if needed.
  2. We can directly reference Dockerfile and let GitHub actions build and run that image.

I personally prefer option (2) if that can be done. Wdut?

image

@laurentsimon
Copy link
Contributor Author

I like option 2 too, which is what I opted for for this #38. If you're OK with the PR, plz LGTM and I'll cut a release to start testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants