Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failing CI #205

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ select = [
"I001", # isort
]

[tool.ruff.pydocstyle]
[tool.ruff.lint.pydocstyle]
convention = "numpy"

[tool.ruff.isort]
[tool.ruff.lint.isort]
# Use a single line between direct and from import
lines-between-types = 1

Expand Down
2 changes: 1 addition & 1 deletion src/scicookie/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def __init__(


def _get_cookiecutter_default_answer(
answer_definition: Union[str, list]
answer_definition: Union[str, list],
) -> str:
if not isinstance(answer_definition, (str, list)):
SciCookieLogs.raise_error(
Expand Down
18 changes: 9 additions & 9 deletions src/scicookie/profiles/base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ project_layout:
choices:
- src
- flat
visible: false
visible: true

build_system:
message: Select one option for the build system
Expand All @@ -96,7 +96,7 @@ build_system:
- maturin
- scikit-build-core
- pybind11
visible: false
visible: true

command_line_interface:
message: Select one option for Command Line Interface (CLI)
Expand All @@ -108,7 +108,7 @@ command_line_interface:
- None
- Click
- Argparse
visible: false
visible: true

documentation_engine:
message: Select one option for the Documentation Engine
Expand All @@ -120,14 +120,14 @@ documentation_engine:
- mkdocs
- sphinx
- jupyter-book
visible: false
visible: true

documentation_url:
message: Type the documentation URL
help: The URL for the documentation page.
type: text
default: "{{ project_url }}"
visible: false
visible: true

use_tools:
message: Select all the initial tools you want to add to your project
Expand All @@ -152,7 +152,7 @@ use_tools:
- hypothesis
- shellcheck
- vulture
visible: false
visible: true

use_containers:
message: Select one option for the container technology for this project
Expand All @@ -164,7 +164,7 @@ use_containers:
- None
- Docker
- Podman
visible: false
visible: true

# doc_template:
# message: Select the template for the Documentation Engine
Expand Down Expand Up @@ -193,7 +193,7 @@ governance_document:
- None
- numpy-governance
- sciml-governance
visible: false
visible: true

roadmap_document:
message: Select one option for a Roadmap document template
Expand All @@ -204,7 +204,7 @@ roadmap_document:
choices:
- None
- pytorch-ignite-roadmap
visible: false
visible: true

git_username:
message: Type the GIT username
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ repos:
{%- if cookiecutter.use_ruff == 'yes' %}
- id: ruff
name: ruff
entry: ruff --fix
entry: ruff --fix --show-fixes
language: system
pass_filenames: true
files: "./"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,20 +66,22 @@ src = ["./"]
exclude = [
'docs',
]

[tool.ruff.lint]
select = [
"E", # pycodestyle
"F", # pyflakes
"D", # pydocstyle
"YTT", # flake8-2020
"RUF", # Ruff-specific rules
"E", # pycodestyle
"F", # pyflakes
"D", # pydocstyle
"YTT", # flake8-2020
"RUF", # Ruff-specific rules
"I001", # isort
]
fixable = ["I001"]

[tool.ruff.pydocstyle]
[tool.ruff.lint.pydocstyle]
convention = "numpy"

[tool.ruff.isort]
[tool.ruff.lint.isort]
# Use a single line between direct and from import
lines-between-types = 1
{% endif %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ dependencies = [
"flake8 >= 4.0.1, < 7",
{% endif %}
{%- if cookiecutter.use_ruff == "yes" -%}
"ruff >= 0.0.278",
"ruff >= 0.2.1",
{% endif %}
{%- if cookiecutter.use_mypy == "yes" -%}
"mypy >= 1.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ dependencies = [
"flake8 >= 4.0.1, < 7",
{% endif %}
{%- if cookiecutter.use_ruff == "yes" -%}
"ruff >= 0.0.278",
"ruff >= 0.2.1",
{% endif %}
{%- if cookiecutter.use_mypy == "yes" -%}
"mypy >= 1.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ dependencies = [
"flake8>=4.0.1, <7",
{% endif %}
{%- if cookiecutter.use_ruff == "yes" -%}
"ruff>=0.0.278",
"ruff>=0.2.1",
{% endif %}
{%- if cookiecutter.use_mypy == "yes" -%}
"mypy>=1.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ dependencies = [
"flake8>=4.0.1, <7",
{% endif %}
{%- if cookiecutter.use_ruff == "yes" -%}
"ruff>=0.0.278",
"ruff>=0.2.1",
{% endif %}
{%- if cookiecutter.use_mypy == "yes" -%}
"mypy>=1.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ dependencies = [
"flake8>=4.0.1, <7",
{% endif %}
{%- if cookiecutter.use_ruff == "yes" -%}
"ruff>=0.0.278",
"ruff>=0.2.1",
{% endif %}
{%- if cookiecutter.use_mypy == "yes" -%}
"mypy>=1.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ pre-commit = "^3.3.2"
flake8 = ">=4.0.1, <7"
{% endif %}
{%- if cookiecutter.use_ruff == "yes" -%}
ruff = "^0.0.278"
ruff = "^0.2.1"
{% endif %}
{%- if cookiecutter.use_mypy == "yes" -%}
mypy = "^1.3.0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ dependencies = [
"flake8 >= 4.0.1, < 7",
{% endif %}
{%- if cookiecutter.use_ruff == "yes" -%}
"ruff >= 0.0.278",
"ruff >= 0.2.1",
{% endif %}
{%- if cookiecutter.use_mypy == "yes" -%}
"mypy >= 1.3.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ dependencies = [
"flake8 >= 4.0.1, < 7",
{% endif %}
{%- if cookiecutter.use_ruff == "yes" -%}
"ruff >= 0.0.278",
"ruff >= 0.2.1",
{% endif %}
{%- if cookiecutter.use_mypy == "yes" -%}
"mypy >= 1.3.0",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
"""Tests for {{ cookiecutter.package_slug }} package."""
{% if cookiecutter.use_pytest == "yes" -%}
{%- if cookiecutter.use_pytest == "yes" -%}
{# keep this line here #}
import pytest
{% endif -%}
{%- endif -%}

{%- if cookiecutter.use_pytest == "yes" and cookiecutter.use_hypothesis == "yes" -%}
{# keep this line here #}
Expand Down Expand Up @@ -44,4 +45,3 @@ def test_content_hypothesis(response_hypothesis):
assert response_hypothesis
{%- endif -%}
{%- endif %}
{# keep this line at the end of the file -#}