Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add console as a supported env variable exporter type #3742

Conversation

codeboten
Copy link
Contributor

Changes

This PR is a follow up to #3740 and #3741. As some languages (the ones I looked at were: python, js, ruby) already support the console type of exporter, I thought it would be good if the spec confirmed it.

Keeping in draft until the other PRs are reviewed.

codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this pull request Oct 26, 2023
This adds support for the standard output exporter for traces and metrics. To remain consistent with other implementations, i used the key `console` as the identifier for the exporter. This change is related to the specification pull request open-telemetry/opentelemetry-specification#3742

Signed-off-by: Alex Boten <aboten@lightstep.com>
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the changelog entry should be moved

@codeboten
Copy link
Contributor Author

Note to reviewers that console is used in python, js, ruby. Java uses logging but after a brief chat w/ @jack-berg, he suggested adding an alias for console in java would be trivial.

codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this pull request Nov 1, 2023
This adds support for the standard output exporter for traces and metrics. To remain consistent with other implementations, i used the key `console` as the identifier for the exporter. This change is related to the specification pull request open-telemetry/opentelemetry-specification#3742

Signed-off-by: Alex Boten <aboten@lightstep.com>
Copy link

github-actions bot commented Nov 7, 2023

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 7, 2023
@codeboten
Copy link
Contributor Author

Not stale, but still blocked by #3740 and #3741.

@svrnm
Copy link
Member

svrnm commented Nov 8, 2023

For completness:

Following the spec compliance matrix the following languages have support for OTEL_TRACES_EXPORTER and besides I listed how an enduser can set the console exporter:

  • Java: logging
  • JS: console
  • Python: console
  • Ruby: console
  • Erlang: no "console" support yet
  • PHP: console

Rust, C++, Go and Swift are listed with not supported/unknown. .NET is also listed as not supported, but the .NET auto instrumentation has the following construct (see https://opentelemetry.io/docs/instrumentation/net/getting-started/ & https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/config.md#internal-logs):

OTEL_TRACES_EXPORTER=none \
  OTEL_METRICS_EXPORTER=none \
  OTEL_LOGS_EXPORTER=none \
  OTEL_DOTNET_AUTO_TRACES_CONSOLE_EXPORTER_ENABLED=true \
  OTEL_DOTNET_AUTO_METRICS_CONSOLE_EXPORTER_ENABLED=true \
  OTEL_DOTNET_AUTO_LOGS_CONSOLE_EXPORTER_ENABLED=true

@pellared
Copy link
Member

pellared commented Nov 8, 2023

Go will add support for console via autoexport thanks to open-telemetry/opentelemetry-go-contrib#4486 (not released yet)

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 16, 2023
@jack-berg jack-berg removed the Stale label Nov 16, 2023
Alex Boten added 2 commits November 20, 2023 20:55
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it.

Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten force-pushed the codeboten/env-var-exporters-console branch from 15892d7 to 1fcefba Compare November 21, 2023 04:58
@codeboten codeboten marked this pull request as ready for review November 21, 2023 04:59
@codeboten codeboten requested review from a team as code owners November 21, 2023 04:59
carlosalberto and others added 4 commits November 27, 2023 09:47
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@carlosalberto carlosalberto merged commit d72b0da into open-telemetry:main Nov 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants