add definition for standard output span exporter #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly a copy of the definition already present for the metrics exporter. It doesn't specify a format for the output itself. Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/add-stdout-exporters-traces-logs
branch
from
1fe871f
to
59bfe95
Compare
codeboten
changed the title
codeboten
commented
Oct 26, 2023
1 task
codeboten
pushed a commit
to codeboten/opentelemetry-specification
that referenced
this pull request
Oct 26, 2023
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it. Signed-off-by: Alex Boten <aboten@lightstep.com>
1 task
tylerbenson
approved these changes
Oct 26, 2023
MrAlias
approved these changes
Oct 30, 2023
carlosalberto
approved these changes
Oct 30, 2023
|
LGTM - don't have a name preference, and I'm actually slightly afraid it's rather late to change the name of all console exporters 😥 |
pellared
approved these changes
Nov 7, 2023
svrnm
reviewed
Nov 7, 2023
arminru
reviewed
Nov 7, 2023
jack-berg
reviewed
Nov 7, 2023
jack-berg
reviewed
Nov 7, 2023
Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com>
jack-berg
approved these changes
Nov 9, 2023
jack-berg
reviewed
Nov 9, 2023
jack-berg
approved these changes
Nov 14, 2023
carlosalberto
approved these changes
Nov 14, 2023
|
Will merge this tomorrow if there are no additional comments. |
carlosalberto
pushed a commit
that referenced
this pull request
Nov 20, 2023
## Changes I couldn't find the definition for a standard output exporter for the logging signal, so I'm submitting one. This is mostly a copy of the definition already present for the metrics exporter. It doesn't specify a format for the output itself. Similar to #3740
codeboten
pushed a commit
to codeboten/opentelemetry-specification
that referenced
this pull request
Nov 21, 2023
This PR is a follow up to open-telemetry#3740 and open-telemetry#3741. As some languages (the ones I looked at were: python, js, ruby) already support the `console` type of exporter, I thought it would be good if the spec confirmed it. Signed-off-by: Alex Boten <aboten@lightstep.com>
carlosalberto
pushed a commit
that referenced
this pull request
Nov 27, 2023
This was referenced Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I couldn't find the definition for a standard output exporter for the trace signal, so I'm submitting one. This is mostly a copy of the definition already present for the metrics exporter. It doesn't specify a format for the output itself.
CHANGELOG.mdfile updated for non-trivial changes