config: NewSDK can return valid TracerProvider #4741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is another attempt at filling in the SDK details for NewSDK. It breaks the open-telemetry#4617 per signal to make it more manageable to review. Part of open-telemetry#4371 Signed-off-by: Alex Boten <aboten@lightstep.com>
added 2 commits
December 21, 2023 12:13
Signed-off-by: Alex Boten <aboten@lightstep.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4741 +/- ##
=======================================
+ Coverage 81.1% 81.2% +0.1%
=======================================
Files 150 150
Lines 10753 10900 +147
=======================================
+ Hits 8725 8858 +133
- Misses 1872 1882 +10
- Partials 156 160 +4
|
pellared
reviewed
Dec 29, 2023
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
pellared
reviewed
Jan 2, 2024
added 2 commits
January 10, 2024 12:11
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
force-pushed
the
codeboten/add-tracer-provider-sdk
branch
from
555d28d
to
f8c02e9
Compare
Co-authored-by: Robert Pająk <pellared@hotmail.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
MadVikingGod
approved these changes
Jan 10, 2024
added 4 commits
January 10, 2024 15:37
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
pellared
reviewed
Jan 11, 2024
pellared
approved these changes
Jan 11, 2024
pellared
changed the title
pellared
changed the title
codeboten
pushed a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Jan 11, 2024
Follow up to open-telemetry#4741, does the same but for metric signal. Fixes open-telemetry#4371 Signed-off-by: Alex Boten <aboten@lightstep.com>
This was referenced Jan 15, 2024
pellared
approved these changes
Jan 16, 2024
Comment on lines
+123
to
+130
| func newResource(res *Resource) (*resource.Resource, error) { | ||
| if res == nil { | ||
| return resource.Default(), nil | ||
| } | ||
| return resource.Merge(resource.Default(), | ||
| resource.NewWithAttributes(semconv.SchemaURL, | ||
| semconv.ServiceName(*res.Attributes.ServiceName), | ||
| )) |
There was a problem hiding this comment.
How about moving to resource.go and adding tests in resource_test.go?
Can we do it in a separate PR?
There was a problem hiding this comment.
Sure, I'll move this next before the meter provider PR
codeboten
pushed a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Jan 16, 2024
Follow up to open-telemetry#4741, does the same but for metric signal. Fixes open-telemetry#4371 Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Jan 22, 2024
Follow up to open-telemetry#4741, does the same but for metric signal. Fixes open-telemetry#4371 Signed-off-by: Alex Boten <aboten@lightstep.com>
codeboten
pushed a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Mar 4, 2024
Follow up to open-telemetry#4741, does the same but for metric signal. Fixes open-telemetry#4371 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
added a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Mar 4, 2024
Follow up to open-telemetry#4741, does the same but for metric signal. Fixes open-telemetry#4371 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
added a commit
to codeboten/opentelemetry-go-contrib
that referenced
this pull request
Apr 12, 2024
Follow up to open-telemetry#4741, does the same but for metric signal. Fixes open-telemetry#4371 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is another attempt at filling in the SDK details for NewSDK. It breaks the #4617 per signal to make it more manageable to review.
Part of #4371