Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.22.0/0.47.0/0.16.0/0.2.0 #4827

Merged
merged 12 commits into from Jan 18, 2024
Merged

Release 1.22.0/0.47.0/0.16.0/0.2.0 #4827

merged 12 commits into from Jan 18, 2024

Conversation

MadVikingGod
Copy link
Contributor

@MadVikingGod MadVikingGod commented Jan 18, 2024 •
edited by pellared

Added

Changed

Fixed

@MadVikingGod MadVikingGod changed the title 1.22.0/0.47.0/0.16.0/0.2.0 Release 1.22.0/0.47.0/0.16.0/0.2.0 Jan 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (a28c68b) 81.3% compared to head (811059e) 81.3%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #4827   +/-   ##
=====================================
  Coverage   81.3%   81.3%           
=====================================
  Files        150     150           
  Lines      10885   10890    +5     
=====================================
+ Hits        8853    8858    +5     
  Misses      1873    1873           
  Partials     159     159
Files Coverage Δ
...github.com/aws/aws-lambda-go/otellambda/version.go 60.0% <100.0%> (ø)
...on/github.com/aws/aws-sdk-go-v2/otelaws/version.go 60.0% <100.0%> (ø)
...hub.com/emicklei/go-restful/otelrestful/version.go 60.0% <100.0%> (ø)
...tation/github.com/gin-gonic/gin/otelgin/version.go 60.0% <100.0%> (ø)
...entation/github.com/gorilla/mux/otelmux/version.go 60.0% <100.0%> (ø)
...ation/github.com/labstack/echo/otelecho/version.go 60.0% <100.0%> (ø)
...n/google.golang.org/grpc/otelgrpc/stats_handler.go 100.0% <100.0%> (ø)
...ntation/google.golang.org/grpc/otelgrpc/version.go 100.0% <100.0%> (ø)
...ntation/gopkg.in/macaron.v1/otelmacaron/version.go 60.0% <100.0%> (ø)
...tation/net/http/httptrace/otelhttptrace/version.go 60.0% <100.0%> (ø)
... and 25 more

pellared
pellared reviewed Jan 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@pellared
Copy link
Member

pellared commented Jan 18, 2024 •
edited

We can consider adding #4825. But only if we do it ASAP as I do not want to delay the release.

@pellared
Copy link
Member

@MadVikingGod why ca5cb71? Instrgen is not released.

pellared
pellared requested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instrgen is not released. It is part of excluded-modules:

@MadVikingGod
Copy link
Contributor Author

instrgen is not released. It is part of excluded-modules:

Should it be in our changelog at all then? Or are we going to keep floating it to the unreleased every cycle?

@pellared
Copy link
Member

instrgen is not released. It is part of excluded-modules:

Should it be in our changelog at all then? Or are we going to keep floating it to the unreleased every cycle?

As for me you can remove it. If we decide to add it at some point we can use the following query to find related PRs: https://github.com/open-telemetry/opentelemetry-go-contrib/pulls?q=is%3Apr+label%3A%22area%3A+instrgen%22+

@MadVikingGod
Copy link
Contributor Author

We can consider adding #4825. But only if we do it ASAP as I do not want to delay the release.

Agreed, it is now included.

pellared
pellared approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR description.

- The `stats.Handler` from `go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc` now does not crash when receiving an unexpected context. (#4825)

was missing.

@MadVikingGod MadVikingGod merged commit 044e09a into open-telemetry:main Jan 18, 2024
21 of 22 checks passed
@MadVikingGod MadVikingGod deleted the mvg/v1.22.0 branch January 18, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@yurishkuro yurishkuro Awaiting requested review from yurishkuro yurishkuro is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MadVikingGod @pellared @dashpole @MrAlias