Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: Move newResource to resource.go and add tests in resource_test.go #4821

Closed
pellared opened this issue Jan 16, 2024 · 1 comment · Fixed by #4824
Closed

config: Move newResource to resource.go and add tests in resource_test.go #4821

pellared opened this issue Jan 16, 2024 · 1 comment · Fixed by #4824
Assignees
@codeboten
Labels
area: config Related to config functionality
Milestone
v1.23.0/v0.48.0/v...

Comments

@pellared
Copy link
Member

How about moving to resource.go and adding tests in resource_test.go?

Originally posted by @pellared in #4741 (comment)
@pellared pellared added the area: config Related to config functionality label Jan 16, 2024
@pellared pellared mentioned this issue Jan 16, 2024
Merged
@codeboten
Copy link
Contributor

please assign to me, thanks!

codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this issue Jan 16, 2024
config: refactor resource code
372a2a0 
This moves the resource code out of config.go and into resource.go.

Fixes open-telemetry#4821

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten mentioned this issue Jan 16, 2024
Merged
MrAlias pushed a commit that referenced this issue Jan 18, 2024
@pellared
config: refactor resource code (#4824)
694c831 
* config: refactor resource code

This moves the resource code out of config.go and into resource.go.

Fixes #4821

Signed-off-by: Alex Boten <aboten@lightstep.com>

* Update resource.go

* Update resource_test.go

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@MrAlias MrAlias added this to the v0.48.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
area: config Related to config functionality
Projects
None yet
Milestone
v1.23.0/v0.48.0/v0.17.0/v0.3.0
Development

Successfully merging a pull request may close this issue.

config: refactor resource code codeboten/opentelemetry-go-contrib
3 participants
@codeboten @pellared @MrAlias