Deprecate otelsarama #4099
Merged
Deprecate otelsarama #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Jul 27, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4099 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 165 165
Lines 10318 10318
=====================================
+ Hits 8183 8186 +3
+ Misses 2000 1998 -2
+ Partials 135 134 -1 |
MrAlias
approved these changes
Jul 28, 2023
dashpole
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards #4091
Per #4090 (review)
What
Deprecate module that is instrumenting
github.com/Shopify/sarama.Next steps
Add support for github.com/IBM/sarama. There are 2 options:
More: IBM/sarama#2510