Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelsarama got deprecated #1080

Closed
julianocosta89 opened this issue Aug 30, 2023 · 3 comments · Fixed by #1083
Closed

otelsarama got deprecated #1080

julianocosta89 opened this issue Aug 30, 2023 · 3 comments · Fixed by #1083

Comments

@julianocosta89
Copy link
Member

As of the new release notes of opentelemetry-go-contrib, otelsarama got deprecated open-telemetry/opentelemetry-go-contrib#4099.

We are currently using it in AccountingService https://github.com/open-telemetry/opentelemetry-demo/blob/main/src/accountingservice/go.mod#L9.

We need to update it to the new supported instrumentation package.

@julianocosta89 julianocosta89 added the bug Something isn't working label Aug 30, 2023
@julianocosta89
Copy link
Member Author

@pellared do we already have a solution for this?
Or the options mentioned in open-telemetry/opentelemetry-go-contrib#4099 are still in discussion?

@julianocosta89 julianocosta89 removed the bug Something isn't working label Aug 31, 2023
@pellared
Copy link
Member

pellared commented Sep 4, 2023

Or the options mentioned in open-telemetry/opentelemetry-go-contrib#4099 are still in discussion?

That is the current state. I am leaning towards Option A and awaiting feedback: IBM/sarama#2510

@julianocosta89
Copy link
Member Author

@pellared actually @cedricziel sent a PR and we already updated it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants