Skip to content

Commit

Permalink
Deprecate otelsarama (#4099)
Browse files Browse the repository at this point in the history
  • Loading branch information
pellared committed Jul 31, 2023
1 parent 384acfd commit bf2ae27
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

- The `go.opentelemetry.io/contrib/instrumentation/github.com/astaxie/beego/otelbeego` module is deprecated. (#4092, #4104)
- The `go.opentelemetry.io/contrib/instrumentation/github.com/go-kit/kit/otelkit` module is deprecated. (#4093, #4104)
- The `go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama` module is deprecated. (#4099)

### Removed

Expand Down
1 change: 0 additions & 1 deletion instrumentation/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ The following instrumentation packages are provided for popular Go packages and
| [github.com/gocql/gocql](./github.com/gocql/gocql/otelgocql) |||
| [github.com/gorilla/mux](./github.com/gorilla/mux/otelmux) | ||
| [github.com/labstack/echo](./github.com/labstack/echo/otelecho) | ||
| [github.com/Shopify/sarama](./github.com/Shopify/sarama/otelsarama) | ||
| [go.mongodb.org/mongo-driver](./go.mongodb.org/mongo-driver/mongo/otelmongo) | ||
| [google.golang.org/grpc](./google.golang.org/grpc/otelgrpc) |||
| [gopkg.in/macaron.v1](./gopkg.in/macaron.v1/otelmacaron) | ||
Expand Down
3 changes: 3 additions & 0 deletions instrumentation/github.com/Shopify/sarama/otelsarama/doc.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,7 @@
// (https://archive.apache.org/dist/kafka/0.11.0.0/RELEASE_NOTES.html)
//
// Based on: https://github.com/DataDog/dd-trace-go/tree/v1/contrib/Shopify/sarama
//
// Deprecated: This module is no longer supported.
// github.com/Shopify/sarama moved to github.com/IBM/sarama.
package otelsarama // import "go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama"
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
semconv "go.opentelemetry.io/otel/semconv/v1.17.0"
"go.opentelemetry.io/otel/trace"

"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama"
"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama" //nolint:staticcheck // This is deprecated and will be removed in the next release.
"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama/example"
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import (
"go.opentelemetry.io/otel"
"go.opentelemetry.io/otel/codes"

"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama"
"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama" //nolint:staticcheck // This is deprecated and will be removed in the next release.
"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama/example"
)

Expand Down
2 changes: 2 additions & 0 deletions instrumentation/github.com/Shopify/sarama/otelsarama/go.mod
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
// Deprecated: This module is no longer supported.
// github.com/Shopify/sarama moved to github.com/IBM/sarama.
module go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama

go 1.19
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama"
"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama" //nolint:staticcheck // This is deprecated and will be removed in the next release.
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/propagation"
sdktrace "go.opentelemetry.io/otel/sdk/trace"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"

"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama"
"go.opentelemetry.io/contrib/instrumentation/github.com/Shopify/sarama/otelsarama" //nolint:staticcheck // This is deprecated and will be removed in the next release.
"go.opentelemetry.io/otel/attribute"
"go.opentelemetry.io/otel/codes"
"go.opentelemetry.io/otel/propagation"
Expand Down

0 comments on commit bf2ae27

Please sign in to comment.