REL: Remove Python upper version from the release branch #24962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the upper version is technically correct for the released version of NumPy (we are sure it will not work on Python 3.13) advertising it creates some problems, mostly for locking resolvers. They try to guess correct versions for non-released Python versions... This is probably an ecosystem or just "reasons", but it seems less useful than trouble to do the correct advertising here. See numpygh-24810 for *way* too much discussion about the why (and you will still be confused afterwards probably, so...). This needs to be fixed or at least documented clearer upstream by PyPA or similar, but... Closes numpygh-24810
rgommers
approved these changes
Oct 20, 2023
1 task
tylerjereddy
added a commit
to tylerjereddy/scipy
that referenced
this pull request
Nov 13, 2023
* this patch against our latest maintenance branch is related to scipygh-19513, and NumPy made a similar decision upstream in numpy/numpy#24962 * the discussions surrounding this are pretty confusing, but it seems like we may need to do it for resolvers like those used by `poetry`... * I suppose this increases the likelihood I have to do `1.11.4`, but it was looking somewhat likely anyway... [skip cirrus] [skip circle]
rgommers
pushed a commit
to scipy/scipy
that referenced
this pull request
Nov 15, 2023
* this patch against our latest maintenance branch is related to gh-19513, and NumPy made a similar decision upstream in numpy/numpy#24962 * the discussions surrounding this are pretty confusing, but it seems like we may need to do it for resolvers like those used by `poetry`... * I suppose this increases the likelihood I have to do `1.11.4`, but it was looking somewhat likely anyway... [skip cirrus] [skip circle]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the upper version is technically correct for the released version of NumPy (we are sure it will not work on Python 3.13) advertising it creates some problems, mostly for locking resolvers. They try to guess correct versions for non-released Python versions...
This is probably an ecosystem or just "reasons", but it seems less useful than trouble to do the correct advertising here.
See gh-24810 for way too much discussion about the why (and you will still be confused afterwards probably, so...).
This needs to be fixed or at least documented clearer upstream by PyPA or similar, but...
Closes gh-24810