relax python upper constraint #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yokomotod
commented
Mar 6, 2024
| @@ -16,7 +16,7 @@ style = "pep440" | |||
| pattern = "^(?P<base>\\d+\\.\\d+\\.\\d+)" | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.9,<3.13" | |||
| python = ">=3.9,<4" | |||
There was a problem hiding this comment.
Some other dependencies have <4 constraint, so ">=3.9" causes problem (those libraries will be downgraded to old version which has no <4 constraint)
ex. fakeredis
Line 504 in 4e76952
yokomotod
force-pushed
the
relax-python-constraint
branch
from
4e76952
to
cf66886
Compare
Hi-king
approved these changes
Mar 6, 2024
mski-iksm
added a commit
to mski-iksm/gokart
that referenced
this pull request
Mar 17, 2024
delete RunWithLock delete old codes add test sort sort delete move rename test rename Change build backend to poetry-core (m3dev#355) Co-authored-by: Keisuke Ogaki <keisuke-ogaki@m3.com> allow distributing typed information (m3dev#356) * allow distributing typed information * restore include relax python constraint (m3dev#357) relock add Update docs/efficient_run_on_multi_workers.rst Co-authored-by: Keisuke OGAKI <hikingko1@gmail.com> set complete_check_at_run=False
kitagry
pushed a commit
that referenced
this pull request
Mar 22, 2024
* add task run lock delete RunWithLock delete old codes add test sort sort delete move rename test rename Change build backend to poetry-core (#355) Co-authored-by: Keisuke Ogaki <keisuke-ogaki@m3.com> allow distributing typed information (#356) * allow distributing typed information * restore include relax python constraint (#357) relock add Update docs/efficient_run_on_multi_workers.rst Co-authored-by: Keisuke OGAKI <hikingko1@gmail.com> set complete_check_at_run=False * add * add blank line * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpyseems un-pinned python upper version numpy/numpy#24962 so now we can relax constraint too.